Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working build on windows #42

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Working build on windows #42

wants to merge 31 commits into from

Conversation

IRooc
Copy link

@IRooc IRooc commented Jan 4, 2023

Thank you for this project, I managed to make it build on windows and by copying freetype.dll and SDL2.dll to the root project folder it also runs.

Main thing was missing freetype2 and the 1 code change you can see. The memset in the read_entire_file was because the second shader somehow had garbage at the end. the memset fixed it. But probably the bug is in passing the string to compile shader you might want to look into that.

I changed the build subsystem to console so you have the printf's available for testing. And I needed to disable some extra warnings (which I know you'd rather not do but I'm not sure how to fix them)

The introduced minirent.h include should have been with " not < and it uses assert.h (maybe minirent.h should include that but that is not your code right?)

Once again thanks for the repo and streaming, I really like them.

By the way, leave this PR open so I can keep it up to date if needed

@IRooc
Copy link
Author

IRooc commented Jan 12, 2023

Updated PR to reflect your latest changes.
And enabled the windows build in the CI

@BillKek
Copy link
Contributor

BillKek commented Feb 9, 2023

quick type_of_file implementation works fine on mingw64+msys2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants